Skip to content

Commit

Permalink
Make private_in_public compatibility lint warn-by-default again
Browse files Browse the repository at this point in the history
  • Loading branch information
petrochenkov committed Sep 4, 2016
1 parent 987b475 commit 3be6d1f
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/librustc/lint/builtin.rs
Expand Up @@ -114,7 +114,7 @@ declare_lint! {

declare_lint! {
pub PRIVATE_IN_PUBLIC,
Deny,
Warn,
"detect private items in public interfaces not caught by the old implementation"
}

Expand Down
4 changes: 4 additions & 0 deletions src/librustc_privacy/diagnostics.rs
Expand Up @@ -17,6 +17,8 @@ A private trait was used on a public type parameter bound. Erroneous code
examples:
```compile_fail,E0445
#![deny(private_in_public)]
trait Foo {
fn dummy(&self) { }
}
Expand Down Expand Up @@ -45,6 +47,8 @@ E0446: r##"
A private type was used in a public type signature. Erroneous code example:
```compile_fail,E0446
#![deny(private_in_public)]
mod Foo {
struct Bar(u32);
Expand Down
2 changes: 2 additions & 0 deletions src/test/compile-fail/issue-28514.rs
Expand Up @@ -8,6 +8,8 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![deny(private_in_public)]

pub use inner::C;

mod inner {
Expand Down
1 change: 1 addition & 0 deletions src/test/compile-fail/issue-30079.rs
Expand Up @@ -8,6 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![deny(private_in_public)]
#![allow(unused)]

struct SemiPriv;
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/private-in-public-warn.rs
Expand Up @@ -13,8 +13,8 @@

#![feature(associated_consts)]
#![feature(associated_type_defaults)]
#![allow(dead_code)]
#![allow(unused_variables)]
#![deny(private_in_public)]
#![allow(unused)]
#![allow(improper_ctypes)]

mod types {
Expand Down
Expand Up @@ -8,6 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![deny(private_in_public)]
#![allow(dead_code)]

extern crate core;
Expand Down

0 comments on commit 3be6d1f

Please sign in to comment.