Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This breaks code that referred to variant names in the same namespace as their enum. Reexport the variants in the old location or alter code to refer to the new locations: ``` pub enum Foo { A, B } fn main() { let a = A; } ``` => ``` pub use self::Foo::{A, B}; pub enum Foo { A, B } fn main() { let a = A; } ``` or ``` pub enum Foo { A, B } fn main() { let a = Foo::A; } ``` [breaking-change]
- Loading branch information
Showing
483 changed files
with
1,714 additions
and
1,110 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at sfackler@3dcd215
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging sfackler/rust/enum-namespace-pt2 = 3dcd215 into auto
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sfackler/rust/enum-namespace-pt2 = 3dcd215 merged ok, testing candidate = c48f31a1
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2317
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2319
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2310
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2317
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2311
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2310
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2310
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2314
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2307
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2306
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2309
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1971
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1967
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1973
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/810
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/804
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/799
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at sfackler@3dcd215
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging sfackler/rust/enum-namespace-pt2 = 3dcd215 into auto
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sfackler/rust/enum-namespace-pt2 = 3dcd215 merged ok, testing candidate = f092793
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2320
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2318
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2311
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2318
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2312
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2311
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2311
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2315
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2308
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2307
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2310
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1972
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1968
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1974
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/811
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/805
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/800
3dcd215
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = f092793