Skip to content

Commit

Permalink
mk: Fix libuv makefile generation on android
Browse files Browse the repository at this point in the history
  • Loading branch information
ILyoan committed Aug 29, 2013
1 parent 26e925a commit 4cf8671
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions mk/rt.mk
Expand Up @@ -173,10 +173,17 @@ LIBUV_MAKEFILE_$(1)_$(2) := $$(CFG_BUILD_DIR)rt/$(1)/stage$(2)/libuv/Makefile
LIBUV_NO_LOAD = run-benchmarks.target.mk run-tests.target.mk \
uv_dtrace_header.target.mk uv_dtrace_provider.target.mk

ifeq ($(OSTYPE_$(1)), linux-androideabi)
$$(LIBUV_MAKEFILE_$(1)_$(2)): $$(LIBUV_GYP)
(cd $(S)src/libuv/ && \
$$(CFG_PYTHON) ./gyp_uv -f make -Dtarget_arch=$$(LIBUV_ARCH_$(1)) -D ninja -DOS=android \
-Goutput_dir=$$(@D) --generator-output $$(@D))
else
$$(LIBUV_MAKEFILE_$(1)_$(2)): $$(LIBUV_GYP)
(cd $(S)src/libuv/ && \
$$(CFG_PYTHON) ./gyp_uv -f make -Dtarget_arch=$$(LIBUV_ARCH_$(1)) -D ninja \
-Goutput_dir=$$(@D) --generator-output $$(@D))
endif

# XXX: Shouldn't need platform-specific conditions here
ifdef CFG_WINDOWSY_$(1)
Expand All @@ -194,8 +201,10 @@ $$(LIBUV_LIB_$(1)_$(2)): $$(LIBUV_DEPS) $$(LIBUV_MAKEFILE_$(1)_$(2))
LDFLAGS="$$(CFG_GCCISH_LINK_FLAGS) $$(LIBUV_FLAGS_$$(HOST_$(1)))" \
CC="$$(CC_$(1))" \
CXX="$$(CXX_$(1))" \
LINK="$$(CXX_$(1))" \
AR="$$(AR_$(1))" \
host=android OS=linux \
PLATFORM=android \
builddir="." \
BUILDTYPE=Release \
NO_LOAD="$$(LIBUV_NO_LOAD)" \
Expand Down

5 comments on commit 4cf8671

@bors
Copy link
Contributor

@bors bors commented on 4cf8671 Aug 29, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from cmr
at ILyoan@4cf8671

@bors
Copy link
Contributor

@bors bors commented on 4cf8671 Aug 29, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging ILyoan/rust/mk_libuv = 4cf8671 into auto

@bors
Copy link
Contributor

@bors bors commented on 4cf8671 Aug 29, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ILyoan/rust/mk_libuv = 4cf8671 merged ok, testing candidate = 698873e

@bors
Copy link
Contributor

@bors bors commented on 4cf8671 Aug 29, 2013

@bors
Copy link
Contributor

@bors bors commented on 4cf8671 Aug 29, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 698873e

Please sign in to comment.