Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix handling of ignored arguments in FFI wrappers for rust functions
Fixes #16441.
- Loading branch information
Showing
2 changed files
with
23 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
struct Empty; | ||
|
||
// This used to cause an ICE | ||
extern "C" fn ice(_a: Empty) {} | ||
|
||
fn main() { | ||
} |
4df0430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from luqmana
at dotdash@4df0430
4df0430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging dotdash/rust/empty_struct_wrapper_arg = 4df0430 into auto
4df0430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotdash/rust/empty_struct_wrapper_arg = 4df0430 merged ok, testing candidate = 56b86aa
4df0430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/816
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/816
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/815
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/816
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/812
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/813
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/812
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/818
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/813
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/812
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/815
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/813
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/813
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/814
4df0430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 56b86aa