Skip to content

Commit

Permalink
Suppress spurious errors inside async fn
Browse files Browse the repository at this point in the history
Fixes #73741
  • Loading branch information
Aaron1011 committed May 17, 2021
1 parent a55748f commit 500503b
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 9 deletions.
30 changes: 21 additions & 9 deletions compiler/rustc_typeck/src/check/generator_interior.rs
Expand Up @@ -89,19 +89,31 @@ impl<'a, 'tcx> InteriorVisitor<'a, 'tcx> {
if let Some((unresolved_type, unresolved_type_span)) =
self.fcx.unresolved_type_vars(&ty)
{
let note = format!(
"the type is part of the {} because of this {}",
self.kind, yield_data.source
);

// If unresolved type isn't a ty_var then unresolved_type_span is None
let span = self
.prev_unresolved_span
.unwrap_or_else(|| unresolved_type_span.unwrap_or(source_span));
self.fcx
.need_type_info_err_in_generator(self.kind, span, unresolved_type)
.span_note(yield_data.span, &*note)
.emit();

// If we encounter an int/float variable, then inference fallback didn't
// finish due to some other error. Don't emit spurious additional errors.
if let ty::Infer(ty::InferTy::IntVar(_) | ty::InferTy::FloatVar(_)) =
unresolved_type.kind()
{
self.fcx
.tcx
.sess
.delay_span_bug(span, &format!("Encountered var {:?}", unresolved_type));
} else {
let note = format!(
"the type is part of the {} because of this {}",
self.kind, yield_data.source
);

self.fcx
.need_type_info_err_in_generator(self.kind, span, unresolved_type)
.span_note(yield_data.span, &*note)
.emit();
}
} else {
// Insert the type into the ordered set.
let scope_span = scope.map(|s| s.span(self.fcx.tcx, self.region_scope_tree));
Expand Down
14 changes: 14 additions & 0 deletions src/test/ui/async-await/issue-73741-type-err.rs
@@ -0,0 +1,14 @@
// edition:2018
//
// Regression test for issue #73741
// Ensures that we don't emit spurious errors when
// a type error ocurrs in an `async fn`

async fn weird() {
1 = 2; //~ ERROR invalid left-hand side

let mut loop_count = 0;
async {}.await
}

fn main() {}
11 changes: 11 additions & 0 deletions src/test/ui/async-await/issue-73741-type-err.stderr
@@ -0,0 +1,11 @@
error[E0070]: invalid left-hand side of assignment
--> $DIR/issue-73741-type-err.rs:8:7
|
LL | 1 = 2;
| - ^
| |
| cannot assign to this expression

error: aborting due to previous error

For more information about this error, try `rustc --explain E0070`.

0 comments on commit 500503b

Please sign in to comment.