Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libnative/io: generic retry() for Unix 64 bit read/write().
Win32/WinSock APIs never call WSASetLastError() with WSAEINTR unless a programmer specifically cancels the ongoing blocking call by a deprecated WinSock1 API WSACancelBlockingCall(). So the errno check was simply removed and retry() became an id function on Windows. Note: Windows' equivalent of SIGINT is always handled in a separate thread: http://msdn.microsoft.com/en-us/library/windows/desktop/ms682541%28v=vs.85%29.aspx "CTRL+C and CTRL+BREAK Signals" Also, incidentally rename a type parameter and clean up some module imports.
- Loading branch information
Showing
3 changed files
with
22 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52e99cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at nodakai@52e99cb
52e99cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nodakai/rust/libnative-c_int = 52e99cb into auto
52e99cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodakai/rust/libnative-c_int = 52e99cb merged ok, testing candidate = afb0c40f
52e99cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1238
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1245
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1244
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1244
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1245
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1238
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1238
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1238
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1243
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1238
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1241
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-opt/builds/75
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-t/builds/75
exception: http://buildbot.rust-lang.org/builders/auto-win32-32-nopt-c/builds/75
52e99cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need more information... Should I assume tests were run in an alphabetical order and it was
for-destruct.rs
that segfaulted? But I don't see how it's related to my patch.52e99cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This segfault has been happening fairly frequently on the bots, it's probably not related to this PR.