Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mark Windows binaries as compatible with ASLR
This is enough for dynamic libraries, but not executables because MinGW does not output a .reloc section even with `--dynamicbase`. It could either be worked around by exporting a DLL symbol from the executable or fixed in MinGW itself.
- Loading branch information
54cb0f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at https://github.com/thestinger/rust/commit/54cb0f6368bcfe996c65d388a0516ac656c606d0
54cb0f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging thestinger/rust/aslr = 54cb0f6 into auto
54cb0f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thestinger/rust/aslr = 54cb0f6 merged ok, testing candidate = 3b65124
54cb0f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/891
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/891
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/890
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/891
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/886
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/887
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/886
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/892
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/887
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/886
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/889
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/887
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/887
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/888
54cb0f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 3b65124