Skip to content

Commit

Permalink
rustdoc: Don't counts ids twice when using --enable-commonmark
Browse files Browse the repository at this point in the history
  • Loading branch information
ollie27 committed Sep 6, 2017
1 parent 2f1ef9e commit 55f9087
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/librustdoc/html/render.rs
Expand Up @@ -1752,9 +1752,13 @@ fn render_markdown(w: &mut fmt::Formatter,
prefix: &str,
scx: &SharedContext)
-> fmt::Result {
let hoedown_output = format!("{}", Markdown(md_text, RenderType::Hoedown));
// We only emit warnings if the user has opted-in to Pulldown rendering.
let output = if render_type == RenderType::Pulldown {
// Save the state of USED_ID_MAP so it only gets updated once even
// though we're rendering twice.
let orig_used_id_map = USED_ID_MAP.with(|map| map.borrow().clone());
let hoedown_output = format!("{}", Markdown(md_text, RenderType::Hoedown));
USED_ID_MAP.with(|map| *map.borrow_mut() = orig_used_id_map);
let pulldown_output = format!("{}", Markdown(md_text, RenderType::Pulldown));
let differences = html_diff::get_differences(&pulldown_output, &hoedown_output);
let differences = differences.into_iter()
Expand All @@ -1775,7 +1779,7 @@ fn render_markdown(w: &mut fmt::Formatter,

pulldown_output
} else {
hoedown_output
format!("{}", Markdown(md_text, RenderType::Hoedown))
};

write!(w, "<div class='docblock'>{}{}</div>", prefix, output)
Expand Down

0 comments on commit 55f9087

Please sign in to comment.