Skip to content

Commit

Permalink
Do not ICE on trait aliases with missing obligations
Browse files Browse the repository at this point in the history
  • Loading branch information
estebank committed Nov 17, 2019
1 parent 5c5b8af commit 578bc43
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/librustc_typeck/astconv.rs
Expand Up @@ -1226,10 +1226,15 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {

/// Transform a `PolyTraitRef` into a `PolyExistentialTraitRef` by
/// removing the dummy `Self` type (`trait_object_dummy_self`).
fn trait_ref_to_existential(&self, trait_ref: ty::TraitRef<'tcx>)
-> ty::ExistentialTraitRef<'tcx> {
fn trait_ref_to_existential(
&self,
trait_ref: ty::TraitRef<'tcx>,
) -> ty::ExistentialTraitRef<'tcx> {
if trait_ref.self_ty() != self.tcx().types.trait_object_dummy_self {
bug!("trait_ref_to_existential called on {:?} with non-dummy Self", trait_ref);
self.tcx().sess.delay_span_bug(DUMMY_SP, &format!(
"trait_ref_to_existential called on {:?} with non-dummy Self",
trait_ref,
));
}
ty::ExistentialTraitRef::erase_self_ty(self.tcx(), trait_ref)
}
Expand Down
12 changes: 12 additions & 0 deletions src/test/ui/issues/issue-65673.rs
@@ -0,0 +1,12 @@
#![feature(trait_alias)]
trait Trait {}
trait WithType {
type Ctx;
}
trait Alias<T> = where T: Trait;

impl<T> WithType for T {
type Ctx = dyn Alias<T>;
//~^ ERROR the size for values of type `(dyn Trait + 'static)` cannot be known at compilation time
}
fn main() {}
17 changes: 17 additions & 0 deletions src/test/ui/issues/issue-65673.stderr
@@ -0,0 +1,17 @@
error[E0277]: the size for values of type `(dyn Trait + 'static)` cannot be known at compilation time
--> $DIR/issue-65673.rs:9:5
|
LL | type Ctx;
| --- associated type defined here
...
LL | impl<T> WithType for T {
| ---------------------- in this `impl` item
LL | type Ctx = dyn Alias<T>;
| ^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
|
= help: the trait `std::marker::Sized` is not implemented for `(dyn Trait + 'static)`
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>

error: aborting due to previous error

For more information about this error, try `rustc --explain E0277`.

0 comments on commit 578bc43

Please sign in to comment.