Skip to content

Commit

Permalink
rustdoc: Fix tuple struct where clause rendering
Browse files Browse the repository at this point in the history
For tuple structs the where clause comes after the definition.
  • Loading branch information
ollie27 committed Jul 25, 2016
1 parent ad264f7 commit 5c0ce87
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 3 deletions.
15 changes: 13 additions & 2 deletions src/librustdoc/html/render.rs
Expand Up @@ -2409,10 +2409,13 @@ fn render_struct(w: &mut fmt::Formatter, it: &clean::Item,
if structhead {"struct "} else {""},
it.name.as_ref().unwrap())?;
if let Some(g) = g {
write!(w, "{}{}", *g, WhereClause(g))?
write!(w, "{}", g)?
}
match ty {
doctree::Plain => {
if let Some(g) = g {
write!(w, "{}", WhereClause(g))?
}
write!(w, " {{\n{}", tab)?;
for field in fields {
if let clean::StructFieldItem(ref ty) = field.inner {
Expand Down Expand Up @@ -2445,9 +2448,17 @@ fn render_struct(w: &mut fmt::Formatter, it: &clean::Item,
_ => unreachable!()
}
}
write!(w, ");")?;
write!(w, ")")?;
if let Some(g) = g {
write!(w, "{}", WhereClause(g))?
}
write!(w, ";")?;
}
doctree::Unit => {
// Needed for PhantomData.
if let Some(g) = g {
write!(w, "{}", WhereClause(g))?
}
write!(w, ";")?;
}
}
Expand Down
16 changes: 16 additions & 0 deletions src/test/rustdoc/issue-34928.rs
@@ -0,0 +1,16 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![crate_name = "foo"]

pub trait Bar {}

// @has foo/struct.Foo.html '//pre' 'pub struct Foo<T>(pub T) where T: Bar;'
pub struct Foo<T>(pub T) where T: Bar;
2 changes: 1 addition & 1 deletion src/test/rustdoc/where.rs
Expand Up @@ -12,7 +12,7 @@

pub trait MyTrait { fn dummy(&self) { } }

// @has foo/struct.Alpha.html '//pre' "pub struct Alpha<A> where A: MyTrait"
// @has foo/struct.Alpha.html '//pre' "pub struct Alpha<A>(_) where A: MyTrait"
pub struct Alpha<A>(A) where A: MyTrait;
// @has foo/trait.Bravo.html '//pre' "pub trait Bravo<B> where B: MyTrait"
pub trait Bravo<B> where B: MyTrait { fn get(&self, B: B); }
Expand Down

0 comments on commit 5c0ce87

Please sign in to comment.