Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bitv: add larger tests, better benchmarks & remove dead code.
There were no tests for iteration etc. with more than 5 elements, i.e. not even going beyond a single word. This situation is rectified. Also, the only benchmarks for `set` were with a constant bit value, which was not indicative of every situation, due to inlining & branch removal. This adds a benchmark at the other end of the spectrum: random input.
- Loading branch information
Showing
1 changed file
with
29 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c81918
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at huonw@5c81918
5c81918
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging huonw/rust/bitv-twiddle = 5c81918 into auto
5c81918
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huonw/rust/bitv-twiddle = 5c81918 merged ok, testing candidate = d59d97c
5c81918
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1154
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1154
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1153
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1154
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1149
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1150
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1149
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1155
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1150
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1149
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1152
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1153
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1151
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1152
5c81918
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = d59d97c