Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The problem was that std::run::Process::new() was unwrap()ing the result of std::io::process::Process::new(), which returns None in the case where the io_error condition is raised to signal failure to start the process. Have std::run::Process::new() similarly return an Option<run::Process> to reflect the fact that a subprocess might have failed to start. Update utility functions run::process_status() and run::process_output() to return Option<ProcessExit> and Option<ProcessOutput>, respectively. Various parts of librustc and librustpkg needed to be updated to reflect these API changes. closes #10754
- Loading branch information
1 parent
00b1adf
commit 5de4270
Showing
12 changed files
with
275 additions
and
153 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
5de4270
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at cadencemarseille@5de4270
5de4270
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging cadencemarseille/rust/issue-10754-std-run-unwrap-on-None = 5de4270 into auto
5de4270
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cadencemarseille/rust/issue-10754-std-run-unwrap-on-None = 5de4270 merged ok, testing candidate = aafed3e
5de4270
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2973
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/817
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/818
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2979
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2084
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2082
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2990
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2080
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2084
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2992
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2081
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2083
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/2159
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2977
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2081
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2083
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/2754
5de4270
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = aafed3e