Skip to content

Commit

Permalink
Add back in previous logic and remove span shrinking
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonathan Turner committed Jan 5, 2017
1 parent 74e5b7d commit 5ead973
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/librustc_typeck/check/mod.rs
Expand Up @@ -4565,7 +4565,6 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
// Check provided lifetime parameters.
let lifetime_defs = segment.map_or(&[][..], |(_, generics)| &generics.regions);
if lifetimes.len() > lifetime_defs.len() {
let span = lifetimes[lifetime_defs.len()].span;
struct_span_err!(self.tcx.sess, span, E0088,
"too many lifetime parameters provided: \
expected {}, found {}",
Expand All @@ -4574,6 +4573,14 @@ impl<'a, 'gcx, 'tcx> FnCtxt<'a, 'gcx, 'tcx> {
.span_label(span, &format!("unexpected lifetime parameter{}",
match lifetimes.len() { 1 => "", _ => "s" }))
.emit();
} else if lifetimes.len() > 0 && lifetimes.len() < lifetime_defs.len() {
struct_span_err!(self.tcx.sess, span, E0090,
"too few lifetime parameters provided: \
expected {}, found {}",
count(lifetime_defs.len()),
count(lifetimes.len()))
.span_label(span, &format!("too few lifetime parameters"))
.emit();
}

// The case where there is not enough lifetime parameters is not checked,
Expand Down

0 comments on commit 5ead973

Please sign in to comment.