Skip to content

Commit

Permalink
Avoid generating QueryMap::extend for each key type
Browse files Browse the repository at this point in the history
  • Loading branch information
Mark-Simulacrum committed May 2, 2021
1 parent 1c2c6b6 commit 61fd56f
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions compiler/rustc_query_system/src/query/plumbing.rs
Expand Up @@ -125,18 +125,15 @@ where
// We use try_lock_shards here since we are called from the
// deadlock handler, and this shouldn't be locked.
let shards = self.shards.try_lock_shards()?;
let shards = shards.iter().enumerate();
jobs.extend(shards.flat_map(|(shard_id, shard)| {
shard.active.iter().filter_map(move |(k, v)| {
for (shard_id, shard) in shards.iter().enumerate() {
for (k, v) in shard.active.iter() {
if let QueryResult::Started(ref job) = *v {
let id = QueryJobId::new(job.id, shard_id, kind);
let info = QueryInfo { span: job.span, query: make_query(tcx, k.clone()) };
Some((id, QueryJobInfo { info, job: job.clone() }))
} else {
None
jobs.insert(id, QueryJobInfo { info, job: job.clone() });
}
})
}));
}
}

Some(())
}
Expand Down

0 comments on commit 61fd56f

Please sign in to comment.