Skip to content

Commit

Permalink
Test suite for overflowing shift operators.
Browse files Browse the repository at this point in the history
Note the tests have been revised to match new semantics for 8- and
16-bit values.
  • Loading branch information
pnkfelix committed Mar 20, 2015
1 parent 19fef72 commit 61ff823
Show file tree
Hide file tree
Showing 9 changed files with 280 additions and 0 deletions.
19 changes: 19 additions & 0 deletions src/test/run-fail/overflowing-lsh-1.rs
@@ -0,0 +1,19 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern:thread '<main>' panicked at 'shift operation overflowed'
// compile-flags: -C debug-assertions

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
let _x = 1_i32 << id(32);
}
19 changes: 19 additions & 0 deletions src/test/run-fail/overflowing-lsh-2.rs
@@ -0,0 +1,19 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern:thread '<main>' panicked at 'shift operation overflowed'
// compile-flags: -C debug-assertions

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
let _x = 1 << id(-1);
}
19 changes: 19 additions & 0 deletions src/test/run-fail/overflowing-lsh-3.rs
@@ -0,0 +1,19 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern:thread '<main>' panicked at 'shift operation overflowed'
// compile-flags: -C debug-assertions

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
let _x = 1_u64 << id(64);
}
33 changes: 33 additions & 0 deletions src/test/run-fail/overflowing-lsh-4.rs
@@ -0,0 +1,33 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern:thread '<main>' panicked at 'shift operation overflowed'
// compile-flags: -C debug-assertions

// This function is checking that our automatic truncation does not
// sidestep the overflow checking.

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
let x = 1_i8 << id(17); // signals overflow when checking is on

// ... but when checking is off, the fallback will truncate the
// input to its lower three bits (= 1). Note that this is *not*
// the behavior of the x86 processor for 8- and 16-bit types,
// but it is necessary to avoid undefined behavior from LLVM.
//
// We check that here, by ensuring the result has only been
// shifted by one place; if overflow checking is turned off, then
// this assertion will pass (and the compiletest driver will
// report that the test did not produce the error expected above).
assert_eq!(x, 2_i8);
}
19 changes: 19 additions & 0 deletions src/test/run-fail/overflowing-rsh-1.rs
@@ -0,0 +1,19 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern:thread '<main>' panicked at 'shift operation overflowed'
// compile-flags: -C debug-assertions

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
let _x = -1_i32 >> id(32);
}
19 changes: 19 additions & 0 deletions src/test/run-fail/overflowing-rsh-2.rs
@@ -0,0 +1,19 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern:thread '<main>' panicked at 'shift operation overflowed'
// compile-flags: -C debug-assertions

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
let _x = -1_i32 >> id(-1);
}
19 changes: 19 additions & 0 deletions src/test/run-fail/overflowing-rsh-3.rs
@@ -0,0 +1,19 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern:thread '<main>' panicked at 'shift operation overflowed'
// compile-flags: -C debug-assertions

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
let _x = -1_i64 >> id(64);
}
33 changes: 33 additions & 0 deletions src/test/run-fail/overflowing-rsh-4.rs
@@ -0,0 +1,33 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern:thread '<main>' panicked at 'shift operation overflowed'
// compile-flags: -C debug-assertions

// This function is checking that our (type-based) automatic
// truncation does not sidestep the overflow checking.

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
let x = 2_i8 >> id(17); // signals overflow when checking is on

// ... but when checking is off, the fallback will truncate the
// input to its lower three bits (= 1). Note that this is *not*
// the behavior of the x86 processor for 8- and 16-bit types,
// but it is necessary to avoid undefined behavior from LLVM.
//
// We check that here, by ensuring the result is not zero; if
// overflow checking is turned off, then this assertion will pass
// (and the compiletest driver will report that the test did not
// produce the error expected above).
assert_eq!(x, 1_i8);
}
100 changes: 100 additions & 0 deletions src/test/run-pass/shift-near-oflo.rs
@@ -0,0 +1,100 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// compile-flags: -C debug-assertions

// Check that we do *not* overflow on a number of edge cases.
// (compare with test/run-fail/overflowing-{lsh,rsh}*.rs)

// (Work around constant-evaluation)
fn id<T>(x: T) -> T { x }

fn main() {
test_left_shift();
test_right_shift();
}

fn test_left_shift() {
// negative rhs can panic, but values in [0,N-1] are okay for iN

macro_rules! tests {
($iN:ty, $uN:ty, $max_rhs:expr, $expect_i:expr, $expect_u:expr) => { {
let x = 1 as $iN << id(0);
assert_eq!(x, 1);
let x = 1 as $uN << id(0);
assert_eq!(x, 1);
let x = 1 as $iN << id($max_rhs);
assert_eq!(x, $expect_i);
let x = 1 as $uN << id($max_rhs);
assert_eq!(x, $expect_u);
// high-order bits on LHS are silently discarded without panic.
let x = 3 as $iN << id($max_rhs);
assert_eq!(x, $expect_i);
let x = 3 as $uN << id($max_rhs);
assert_eq!(x, $expect_u);
} }
}

let x = 1_i8 << id(0);
assert_eq!(x, 1);
let x = 1_u8 << id(0);
assert_eq!(x, 1);
let x = 1_i8 << id(7);
assert_eq!(x, std::i8::MIN);
let x = 1_u8 << id(7);
assert_eq!(x, 0x80);
// high-order bits on LHS are silently discarded without panic.
let x = 3_i8 << id(7);
assert_eq!(x, std::i8::MIN);
let x = 3_u8 << id(7);
assert_eq!(x, 0x80);

// above is (approximately) expanded from:
tests!(i8, u8, 7, std::i8::MIN, 0x80_u8);

tests!(i16, u16, 15, std::i16::MIN, 0x8000_u16);
tests!(i32, u32, 31, std::i32::MIN, 0x8000_0000_u32);
tests!(i64, u64, 63, std::i64::MIN, 0x8000_0000_0000_0000_u64);
}

fn test_right_shift() {
// negative rhs can panic, but values in [0,N-1] are okay for iN

macro_rules! tests {
($iN:ty, $uN:ty, $max_rhs:expr,
$signbit_i:expr, $highbit_i:expr, $highbit_u:expr) =>
{ {
let x = 1 as $iN >> id(0);
assert_eq!(x, 1);
let x = 1 as $uN >> id(0);
assert_eq!(x, 1);
let x = $highbit_i >> id($max_rhs-1);
assert_eq!(x, 1);
let x = $highbit_u >> id($max_rhs);
assert_eq!(x, 1);
// sign-bit is carried by arithmetic right shift
let x = $signbit_i >> id($max_rhs);
assert_eq!(x, -1);
// low-order bits on LHS are silently discarded without panic.
let x = $highbit_i + 1 >> id($max_rhs-1);
assert_eq!(x, 1);
let x = $highbit_u + 1 >> id($max_rhs);
assert_eq!(x, 1);
let x = $signbit_i + 1 >> id($max_rhs);
assert_eq!(x, -1);
} }
}

tests!(i8, u8, 7, std::i8::MIN, 0x40_i8, 0x80_u8);
tests!(i16, u16, 15, std::i16::MIN, 0x4000_u16, 0x8000_u16);
tests!(i32, u32, 31, std::i32::MIN, 0x4000_0000_u32, 0x8000_0000_u32);
tests!(i64, u64, 63, std::i64::MIN,
0x4000_0000_0000_0000_u64, 0x8000_0000_0000_0000_u64);
}

0 comments on commit 61ff823

Please sign in to comment.