Skip to content

Commit

Permalink
dump lints _after_ parsing macros
Browse files Browse the repository at this point in the history
  • Loading branch information
mark-i-m committed Jul 24, 2018
1 parent b206aed commit 6cb09cc
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
16 changes: 9 additions & 7 deletions src/librustc_driver/driver.rs
Expand Up @@ -697,13 +697,6 @@ pub fn phase_1_parse_input<'a>(
hir_stats::print_ast_stats(&krate, "PRE EXPANSION AST STATS");
}

// Add all buffered lints from the `ParseSess` to the `Session`.
let mut parse_sess_buffered = sess.parse_sess.buffered_lints.borrow_mut();
for BufferedEarlyLint{id, span, msg, lint_id} in parse_sess_buffered.drain(..) {
let lint = lint::Lint::from_parser_lint_id(lint_id);
sess.buffer_lint(lint, id, span, &msg);
}

Ok(krate)
}

Expand Down Expand Up @@ -1074,6 +1067,15 @@ where
)
});

// Add all buffered lints from the `ParseSess` to the `Session`.
sess.parse_sess.buffered_lints.with_lock(|buffered_lints| {
info!("{} parse sess buffered_lints", buffered_lints.len());
for BufferedEarlyLint{id, span, msg, lint_id} in buffered_lints.drain(..) {
let lint = lint::Lint::from_parser_lint_id(lint_id);
sess.buffer_lint(lint, id, span, &msg);
}
});

// Done with macro expansion!

after_expand(&krate)?;
Expand Down
6 changes: 3 additions & 3 deletions src/libsyntax/parse/mod.rs
Expand Up @@ -96,14 +96,14 @@ impl ParseSess {
id: NodeId,
msg: &str,
) {
self.buffered_lints
.borrow_mut()
.push(BufferedEarlyLint{
self.buffered_lints.with_lock(|buffered_lints| {
buffered_lints.push(BufferedEarlyLint{
span: span.into(),
id,
msg: msg.into(),
lint_id,
});
});
}
}

Expand Down

0 comments on commit 6cb09cc

Please sign in to comment.