Skip to content

Commit

Permalink
rephrase some comments according to remarks in the PR
Browse files Browse the repository at this point in the history
  • Loading branch information
TeXitoi committed Oct 28, 2014
1 parent 7c6a4cc commit 7017fb0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/test/bench/shootout-reverse-complement.rs
Expand Up @@ -62,7 +62,6 @@ impl Tables {
}
let mut table16 = [0, ..1 << 16];
for (i, v) in table16.iter_mut().enumerate() {
// assume little endian
*v = table8[i & 255] as u16 << 8 |
table8[i >> 8] as u16;
}
Expand Down Expand Up @@ -104,9 +103,10 @@ impl Tables {

/// Reads all remaining bytes from the stream.
fn read_to_end<R: Reader>(r: &mut R) -> IoResult<Vec<u8>> {
// FIXME: this method is a temporary workaround for jemalloc on
// linux. Replace it with Reader::read_to_end() once the jemalloc
// issue has been fixed.
// As reading the input stream in memory is a bottleneck, we tune
// Reader::read_to_end() with a fast growing policy to limit
// recopies. If MREMAP_RETAIN is implemented in the linux kernel
// and jemalloc use it, this trick will become useless.
const CHUNK: uint = 64 * 1024;

let mut vec = Vec::with_capacity(CHUNK);
Expand Down

5 comments on commit 7017fb0

@bors
Copy link
Contributor

@bors bors commented on 7017fb0 Oct 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at TeXitoi@7017fb0

@bors
Copy link
Contributor

@bors bors commented on 7017fb0 Oct 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging TeXitoi/rust/simplify-reverse-complement = 7017fb0 into auto

@bors
Copy link
Contributor

@bors bors commented on 7017fb0 Oct 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TeXitoi/rust/simplify-reverse-complement = 7017fb0 merged ok, testing candidate = 18a3db6

@bors
Copy link
Contributor

@bors bors commented on 7017fb0 Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 7017fb0 Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 18a3db6

Please sign in to comment.