Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rustpkg: Set exit codes properly and make tests take advantage of that
When I started writing the rustpkg tests, task failure didn't set the exit code properly. But bblum's work from July fixed that. Hooray! I just didn't know about it till now. So, now rustpkg uses exit codes in a more conventional way, and some of the tests are simpler. The bigger issue will be to make task failure propagate the error message. Right now, rustpkg does most of the work in separate tasks, which means if a task fails, rustpkg can't distinguish between different types of failure (see #3408)
- Loading branch information
1 parent
80878ff
commit 7472bae
Showing
4 changed files
with
72 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from catamorphism, metajack
at catamorphism@7472bae
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging catamorphism/rust/rustpkg-exitcodes = 7472bae into auto
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catamorphism/rust/rustpkg-exitcodes = 7472bae merged ok, testing candidate = e8d7de0f
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1957
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1953
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1063
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1062
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1971
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1063
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1063
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1972
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1063
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1063
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1956
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1061
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1063
exception: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/1740
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from catamorphism, metajack
at catamorphism@7472bae
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging catamorphism/rust/rustpkg-exitcodes = 7472bae into auto
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catamorphism/rust/rustpkg-exitcodes = 7472bae merged ok, testing candidate = 399a425
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1954
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1958
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1064
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1063
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1972
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1064
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1064
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1973
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1064
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1064
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/1143
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1957
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1062
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1064
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/1741
7472bae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 399a425