Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Check object lifetime bounds in coercions, not just trait bounds. Fixes
- Loading branch information
1 parent
4a382d7
commit 7876cf9
Showing
2 changed files
with
42 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
src/test/compile-fail/region-object-lifetime-in-coercion.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// Test that attempts to implicitly coerce a value into an | ||
// object respect the lifetime bound on the object type. | ||
|
||
fn a(v: &[u8]) -> Box<Clone + 'static> { | ||
let x: Box<Clone + 'static> = box v; //~ ERROR does not outlive | ||
x | ||
} | ||
|
||
fn b(v: &[u8]) -> Box<Clone + 'static> { | ||
box v //~ ERROR does not outlive | ||
} | ||
|
||
fn c(v: &[u8]) -> Box<Clone> { | ||
box v // OK thanks to lifetime elision | ||
} | ||
|
||
fn d<'a,'b>(v: &'a [u8]) -> Box<Clone+'b> { | ||
box v //~ ERROR does not outlive | ||
} | ||
|
||
fn e<'a:'b,'b>(v: &'a [u8]) -> Box<Clone+'b> { | ||
box v // OK, thanks to 'a:'b | ||
} | ||
|
||
fn main() { } |
7876cf9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nikomatsakis@7876cf9
7876cf9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nikomatsakis/rust/issue-18055 = 7876cf9 into auto
7876cf9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikomatsakis/rust/issue-18055 = 7876cf9 merged ok, testing candidate = d670919
7876cf9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1856
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1855
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1848
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1855
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1849
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1848
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1848
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1852
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1846
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1845
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1848
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1503
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1503
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1506
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/343
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/344
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/335
7876cf9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = d670919