Skip to content

Commit

Permalink
Check object lifetime bounds in coercions, not just trait bounds. Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
nikomatsakis committed Oct 16, 2014
1 parent 4a382d7 commit 7876cf9
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/librustc/middle/typeck/check/mod.rs
Expand Up @@ -1681,10 +1681,17 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
self.register_unsize_obligations(span, &**u)
}
ty::UnsizeVtable(ref ty_trait, self_ty) => {
// If the type is `Foo+'a`, ensures that the type
// being cast to `Foo+'a` implements `Foo`:
vtable2::register_object_cast_obligations(self,
span,
ty_trait,
self_ty);

// If the type is `Foo+'a`, ensures that the type
// being cast to `Foo+'a` outlives `'a`:
let origin = infer::RelateObjectBound(span);
self.register_region_obligation(origin, self_ty, ty_trait.bounds.region_bound);
}
}
}
Expand Down
35 changes: 35 additions & 0 deletions src/test/compile-fail/region-object-lifetime-in-coercion.rs
@@ -0,0 +1,35 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test that attempts to implicitly coerce a value into an
// object respect the lifetime bound on the object type.

fn a(v: &[u8]) -> Box<Clone + 'static> {
let x: Box<Clone + 'static> = box v; //~ ERROR does not outlive
x
}

fn b(v: &[u8]) -> Box<Clone + 'static> {
box v //~ ERROR does not outlive
}

fn c(v: &[u8]) -> Box<Clone> {
box v // OK thanks to lifetime elision
}

fn d<'a,'b>(v: &'a [u8]) -> Box<Clone+'b> {
box v //~ ERROR does not outlive
}

fn e<'a:'b,'b>(v: &'a [u8]) -> Box<Clone+'b> {
box v // OK, thanks to 'a:'b
}

fn main() { }

5 comments on commit 7876cf9

@bors
Copy link
Contributor

@bors bors commented on 7876cf9 Oct 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from pcwalton
at nikomatsakis@7876cf9

@bors
Copy link
Contributor

@bors bors commented on 7876cf9 Oct 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging nikomatsakis/rust/issue-18055 = 7876cf9 into auto

@bors
Copy link
Contributor

@bors bors commented on 7876cf9 Oct 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nikomatsakis/rust/issue-18055 = 7876cf9 merged ok, testing candidate = d670919

@bors
Copy link
Contributor

@bors bors commented on 7876cf9 Oct 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 7876cf9 Oct 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = d670919

Please sign in to comment.