Skip to content

Commit

Permalink
librustc: Remove special case for old reflection visitor.
Browse files Browse the repository at this point in the history
  • Loading branch information
luqmana committed Oct 16, 2014
1 parent 6f9b3b5 commit 7899248
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions src/librustc/middle/trans/base.rs
Expand Up @@ -2468,24 +2468,6 @@ pub fn get_fn_llvm_attributes(ccx: &CrateContext, fn_ty: ty::t)
.arg(idx, llvm::DereferenceableAttribute(llsz));
}

// The visit glue deals only with opaque pointers so we don't
// actually know the concrete type of Self thus we don't know how
// many bytes to mark as dereferenceable so instead we just mark
// it as nonnull which still holds true
ty::ty_rptr(b, ty::mt { ty: it, mutbl }) if match ty::get(it).sty {
ty::ty_param(_) => true, _ => false
} && mutbl == ast::MutMutable => {
attrs.arg(idx, llvm::NoAliasAttribute)
.arg(idx, llvm::NonNullAttribute);

match b {
ReLateBound(_, BrAnon(_)) => {
attrs.arg(idx, llvm::NoCaptureAttribute);
}
_ => {}
}
}

// `&mut` pointer parameters never alias other parameters, or mutable global data
//
// `&T` where `T` contains no `UnsafeCell<U>` is immutable, and can be marked as both
Expand Down

21 comments on commit 7899248

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from nick29581
at luqmana@7899248

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging luqmana/rust/remove-reflection = 7899248 into auto

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luqmana/rust/remove-reflection = 7899248 merged ok, testing candidate = e07b958e

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from nick29581
at luqmana@7899248

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging luqmana/rust/remove-reflection = 7899248 into auto

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luqmana/rust/remove-reflection = 7899248 merged ok, testing candidate = 9859b516

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from nick29581
at luqmana@7899248

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging luqmana/rust/remove-reflection = 7899248 into auto

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luqmana/rust/remove-reflection = 7899248 merged ok, testing candidate = 2083ea88

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from nick29581
at luqmana@7899248

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging luqmana/rust/remove-reflection = 7899248 into auto

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luqmana/rust/remove-reflection = 7899248 merged ok, testing candidate = 6b3e3c92

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from nick29581
at luqmana@7899248

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging luqmana/rust/remove-reflection = 7899248 into auto

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luqmana/rust/remove-reflection = 7899248 merged ok, testing candidate = 8b97973

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 7899248 Oct 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 8b97973

Please sign in to comment.