Skip to content

Commit

Permalink
move lifetime suggestion note to after the error
Browse files Browse the repository at this point in the history
Closes #15433.
  • Loading branch information
ftxqxd committed Jul 5, 2014
1 parent 935da07 commit 7926aee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/librustc/middle/typeck/infer/error_reporting.rs
Expand Up @@ -676,10 +676,10 @@ impl<'a> ErrorReporting for InferCtxt<'a> {
var_origins: &[RegionVariableOrigin],
trace_origins: &[(TypeTrace, ty::type_err)],
same_regions: &[SameRegions]) {
self.give_suggestion(same_regions);
for vo in var_origins.iter() {
self.report_inference_failure(vo.clone());
}
self.give_suggestion(same_regions);
for &(ref trace, terr) in trace_origins.iter() {
self.report_type_error(trace.clone(), &terr);
}
Expand Down

5 comments on commit 7926aee

@bors
Copy link
Contributor

@bors bors commented on 7926aee Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from pcwalton
at ftxqxd@7926aee

@bors
Copy link
Contributor

@bors bors commented on 7926aee Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging P1start/rust/lifetime-suggest = 7926aee into auto

@bors
Copy link
Contributor

@bors bors commented on 7926aee Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1start/rust/lifetime-suggest = 7926aee merged ok, testing candidate = ea037d0

@bors
Copy link
Contributor

@bors bors commented on 7926aee Jul 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = ea037d0

Please sign in to comment.