Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mk: Fix configuration of version commit information
Commit bec2ee7 started quoting paths discovered as part of the `probe` function, which includes git. The `make` `wildcard` function appears to be incompatible with quoted paths so this check in the makefile now fails. Employing `wildcard` here appears to only re-verify that git actually exists, which the configure script already did, so I've just removed it. Additionally, with the quoted paths the `subst` function should no longer be needed, so I've removed it as well. Closes #18771
- Loading branch information
7c36336
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at brson@7c36336
7c36336
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging brson/rust/winescapefixes = 7c36336 into auto
7c36336
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brson/rust/winescapefixes = 7c36336 merged ok, testing candidate = 40fb87d
7c36336
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2204
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2203
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2196
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2203
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2197
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2196
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2196
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2200
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2193
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2192
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2196
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1855
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1852
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1859
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/696
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/689
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/683
7c36336
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 40fb87d