Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename include_bin! to include_bytes!
According to [RFC 344][], methods that return `&[u8]` should have names ending in `bytes`. Though `include_bin!` is a macro not a method, it seems reasonable to follow the convention anyway. We keep the old name around for now, but trigger a deprecation warning when it is used. [RFC 344]: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md [breaking-change]
- Loading branch information
1 parent
62fb41c
commit 85c1a4b
Showing
9 changed files
with
34 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85c1a4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/lfairy/rust/commit/85c1a4b1ba09dae786b3554e0ab596814efabe0e
85c1a4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging lfairy/rust/rename-include-bin = 85c1a4b into auto
85c1a4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status: {"merge_sha": "7e11b22713aebd28ceaaa2ecef937c9b9d247c2f"}
85c1a4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lfairy/rust/rename-include-bin = 85c1a4b merged ok, testing candidate = 7e11b22
85c1a4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2842
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2837
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2838
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2829
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2828
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2832
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2824
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2824
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2493
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2490
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/1331
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/1322
85c1a4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 7e11b22
85c1a4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 7e11b22