Skip to content

Commit

Permalink
Add test for current behaviour.
Browse files Browse the repository at this point in the history
This commit adds a test that causes a suggestion to replace `extern
crate` with `use` when doing so would cause a compliation error, as the
new name of the import would not be added to the prelude if a `use` was
used.
  • Loading branch information
davidtwco committed Apr 25, 2019
1 parent e305df1 commit 8a47e08
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
14 changes: 14 additions & 0 deletions src/test/ui/suggestions/issue-57672.rs
@@ -0,0 +1,14 @@
// aux-build:foo.rs
// compile-flags:--extern foo
// edition:2018

#![deny(unused_extern_crates)]

extern crate foo as foo_renamed;
//~^ ERROR `extern crate` is not idiomatic in the new edition

pub mod m {
pub use foo_renamed::Foo;
}

fn main() {}
14 changes: 14 additions & 0 deletions src/test/ui/suggestions/issue-57672.stderr
@@ -0,0 +1,14 @@
error: `extern crate` is not idiomatic in the new edition
--> $DIR/issue-57672.rs:7:1
|
LL | extern crate foo as foo_renamed;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert it to a `use`
|
note: lint level defined here
--> $DIR/issue-57672.rs:5:9
|
LL | #![deny(unused_extern_crates)]
| ^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

0 comments on commit 8a47e08

Please sign in to comment.