Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed type signature of uninhabited method.
Added unit test to prevent similar mistakes from happening again. The previous method was wrong because it dereferenced a pointer to a void type to match on the result. No self pointer was needed, and the correct method signature took the self value by value.
- Loading branch information
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at mstewartgallus@8c5de02
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging sstewartgallus/rust/incoming = 8c5de02 into auto
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sstewartgallus/rust/incoming = 8c5de02 merged ok, testing candidate = c1bf6a43
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
http://buildbot.rust-lang.org/builders/auto-mac/builds/1245
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at mstewartgallus@8c5de02
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging sstewartgallus/rust/incoming = 8c5de02 into auto
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sstewartgallus/rust/incoming = 8c5de02 merged ok, testing candidate = 290a2eb
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
http://buildbot.rust-lang.org/builders/auto-linux/builds/1302
http://buildbot.rust-lang.org/builders/auto-win/builds/1297
http://buildbot.rust-lang.org/builders/auto-mac/builds/1315
8c5de02
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding incoming to auto = 290a2eb