Skip to content

Commit

Permalink
Test fixes and rebase conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
alexcrichton committed Oct 20, 2014
1 parent 9d5d97b commit 96445a5
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
12 changes: 6 additions & 6 deletions src/libnative/io/process.rs
Expand Up @@ -489,15 +489,15 @@ fn make_command_line(prog: &CString, args: &[CString]) -> String {
}
let argvec: Vec<char> = arg.chars().collect();
for i in range(0u, argvec.len()) {
append_char_at(cmd, &argvec, i);
append_char_at(cmd, argvec.as_slice(), i);
}
if quote {
cmd.push('"');
}
}

fn append_char_at(cmd: &mut String, arg: &Vec<char>, i: uint) {
match *arg.get(i) {
fn append_char_at(cmd: &mut String, arg: &[char], i: uint) {
match arg[i] {
'"' => {
// Escape quotes.
cmd.push_str("\\\"");
Expand All @@ -517,11 +517,11 @@ fn make_command_line(prog: &CString, args: &[CString]) -> String {
}
}

fn backslash_run_ends_in_quote(s: &Vec<char>, mut i: uint) -> bool {
while i < s.len() && *s.get(i) == '\\' {
fn backslash_run_ends_in_quote(s: &[char], mut i: uint) -> bool {
while i < s.len() && s[i] == '\\' {
i += 1;
}
return i < s.len() && *s.get(i) == '"';
return i < s.len() && s[i] == '"';
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/libnative/task.rs
Expand Up @@ -345,7 +345,7 @@ mod tests {
#[test]
fn spawn_inherits() {
let (tx, rx) = channel();
spawn(proc() {
TaskBuilder::new().spawner(NativeSpawner).spawn(proc() {
spawn(proc() {
let mut task: Box<Task> = Local::take();
match task.maybe_take_runtime::<Ops>() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/writing-to-immutable-vec.rs
Expand Up @@ -11,5 +11,5 @@

fn main() {
let v: Vec<int> = vec!(1, 2, 3);
v[1] = 4; //~ ERROR cannot assign
v[1] = 4; //~ ERROR cannot borrow immutable local variable `v` as mutable
}
2 changes: 1 addition & 1 deletion src/test/run-pass/vector-sort-failure-safe.rs
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

use std::task;
use std::sync::atomics::{AtomicUint, INIT_ATOMIC_UINT, Relaxed};
use std::sync::atomic::{AtomicUint, INIT_ATOMIC_UINT, Relaxed};
use std::rand::{task_rng, Rng, Rand};

const REPEATS: uint = 5;
Expand Down

5 comments on commit 96445a5

@bors
Copy link
Contributor

@bors bors commented on 96445a5 Oct 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from aturon
at alexcrichton@96445a5

@bors
Copy link
Contributor

@bors bors commented on 96445a5 Oct 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging alexcrichton/rust/spring-cleaning = 96445a5 into auto

@bors
Copy link
Contributor

@bors bors commented on 96445a5 Oct 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexcrichton/rust/spring-cleaning = 96445a5 merged ok, testing candidate = 7d0cc44

@bors
Copy link
Contributor

@bors bors commented on 96445a5 Oct 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 96445a5 Oct 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 7d0cc44

Please sign in to comment.