Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
trans: use types from argument patterns instead of the function signa…
…ture. This fixes ICEs caused by late-bound lifetimes ending up in argument datum types and being used in cleanup - user Drop impl's would then fail to monomorphize if the type was used to look up the impl of a method call - which happens in trans now, I presume for multidispatch.
- Loading branch information
Showing
4 changed files
with
45 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![feature(unsafe_destructor)] | ||
|
||
pub struct Foo<T>; | ||
|
||
impl<T> Iterator<T> for Foo<T> { | ||
fn next(&mut self) -> Option<T> { | ||
None | ||
} | ||
} | ||
|
||
#[unsafe_destructor] | ||
impl<T> Drop for Foo<T> { | ||
fn drop(&mut self) { | ||
self.next(); | ||
} | ||
} | ||
|
||
pub fn foo<'a>(_: Foo<&'a ()>) {} | ||
|
||
pub fn main() {} |
96ba514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from nikomatsakis
at eddyb@96ba514
96ba514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging eddyb/rust/free-region-args = 96ba514 into auto
96ba514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eddyb/rust/free-region-args = 96ba514 merged ok, testing candidate = 7e66231
96ba514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2034
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2033
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2026
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2033
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2028
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2027
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2027
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2031
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2024
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2024
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2027
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1684
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1677
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1685
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/523
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/519
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/512
96ba514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 7e66231