address review comments

rust-lang · Sep 24, 2017 · 9c4898e · 9c4898e
1 parent c72a979
commit 9c4898e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/librustc/mir/mod.rs b/src/librustc/mir/mod.rs
@@ -491,7 +491,7 @@ pub struct LocalDecl<'tcx> {
     /// The *lexical* visibility scope the local is defined
     /// in. If the local was defined in a let-statement, this
     /// is *within* the let-statement, rather than outside
-    /// of iit.
+    /// of it.
     pub lexical_scope: VisibilityScope,
 }
 

diff --git a/src/librustc_driver/driver.rs b/src/librustc_driver/driver.rs
@@ -1005,10 +1005,6 @@ pub fn phase_3_run_analysis_passes<'tcx, F, R>(sess: &'tcx Session,
     // What we need to run borrowck etc.
 
     passes.push_pass(MIR_VALIDATED, mir::transform::qualify_consts::QualifyAndPromoteConstants);
-
-    // FIXME: ariel points SimplifyBranches should run after
-    // mir-borrowck; otherwise code within `if false { ... }` would
-    // not be checked.
     passes.push_pass(MIR_VALIDATED, mir::transform::simplify::SimplifyCfg::new("qualify-consts"));
     passes.push_pass(MIR_VALIDATED, mir::transform::nll::NLL);