Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Index cross-mod type definition and implementation properly in rustdoc
A structure's definition and implementation may be cross-module. If the implementing module is parsed before defining module, the fully qualified name of the structure won't be present for the implementation to use when being indexed. So caches such 'orphan' implementation and indexes it at the end of crate parsing. Closes #10284.
- Loading branch information
Showing
1 changed file
with
51 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a337592
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at edwardw@a337592
a337592
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging edwardw/rust/rdoc = a337592 into auto
a337592
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edwardw/rust/rdoc = a337592 merged ok, testing candidate = 3ade321
a337592
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4624
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/2466
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/2466
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4621
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/3721
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3727
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4637
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/3725
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3731
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4639
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/3725
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3730
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/3798
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1616
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4633
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/3734
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3741
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4398
a337592
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 3ade321