Skip to content

Commit

Permalink
Add an insert_with_key function to the Map trait
Browse files Browse the repository at this point in the history
  • Loading branch information
killerswan authored and brson committed Nov 25, 2012
1 parent 455d73c commit a343e43
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 1 deletion.
25 changes: 24 additions & 1 deletion src/libstd/map.rs
Expand Up @@ -27,7 +27,15 @@ pub trait Map<K:Eq IterBytes Hash Copy, V: Copy> {
*
* Returns true if the key did not already exist in the map
*/
fn insert(v: K, v: V) -> bool;
fn insert(key: K, value: V) -> bool;

/**
* Add a value to the map.
*
* If the map contains a value for the key, use the function
* to set a new value.
*/
fn insert_with_key(ff: fn(K, V, V) -> V, key: K, value: V) -> bool;

/// Returns true if the map contains a value for the specified key
pure fn contains_key(key: K) -> bool;
Expand Down Expand Up @@ -264,6 +272,14 @@ pub mod chained {
}
}

fn insert_with_key(ff: fn(K, V, V) -> V, key: K, val: V) -> bool {
// this can be optimized but first lets see if it compiles...
match self.find(key) {
None => return self.insert(key, val),
Some(copy orig) => return self.insert(key, ff(key, orig, val))
}
}

pure fn get(k: K) -> V {
let opt_v = self.find(k);
if opt_v.is_none() {
Expand Down Expand Up @@ -447,6 +463,13 @@ impl<K: Eq IterBytes Hash Copy, V: Copy> @Mut<LinearMap<K, V>>:
}
}

fn insert_with_key(ff: fn(K, V, V) -> V, key: K, val: V) -> bool {
match self.find(key) {
None => return self.insert(key, val),
Some(copy orig) => return self.insert(key, ff(key, orig, val)),
}
}

fn remove(key: K) -> bool {
do self.borrow_mut |p| {
p.remove(&key)
Expand Down
7 changes: 7 additions & 0 deletions src/libstd/smallintmap.rs
Expand Up @@ -103,6 +103,13 @@ impl<V: Copy> SmallIntMap<V>: map::Map<uint, V> {
pure fn find(key: uint) -> Option<V> { find(self, key) }
fn rehash() { fail }

fn insert_with_key(ff: fn(uint, V, V) -> V, key: uint, val: V) -> bool {
match self.find(key) {
None => return self.insert(key, val),
Some(copy orig) => return self.insert(key, ff(key, orig, val)),
}
}

pure fn each(it: fn(key: uint, value: V) -> bool) {
self.each_ref(|k, v| it(*k, *v))
}
Expand Down
8 changes: 8 additions & 0 deletions src/test/run-pass/class-impl-very-parameterized-trait.rs
Expand Up @@ -61,6 +61,14 @@ impl<T: Copy> cat<T> : Map<int, T> {
else { None }
}

fn insert_with_key(ff: fn(+k: int, +v0: T, +v1: T) -> T, +key: int, +val: T) -> bool {
match self.find(key) {
None => return self.insert(key, val),
Some(copy orig) => return self.insert(key, ff(key, orig, val))
}
}


fn remove(+k:int) -> bool {
match self.find(k) {
Some(x) => {
Expand Down

0 comments on commit a343e43

Please sign in to comment.