Skip to content

Commit

Permalink
avoid "type must be known here" errors if tainted
Browse files Browse the repository at this point in the history
  • Loading branch information
nikomatsakis committed Apr 12, 2016
1 parent ccaa2f8 commit a4e0e6b
Show file tree
Hide file tree
Showing 2 changed files with 72 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/librustc_typeck/check/mod.rs
Expand Up @@ -4800,9 +4800,11 @@ fn structurally_resolve_type_or_else<'a, 'tcx, F>(fcx: &FnCtxt<'a, 'tcx>,

// If not, error.
if alternative.is_ty_var() || alternative.references_error() {
fcx.type_error_message(sp, |_actual| {
"the type of this value must be known in this context".to_string()
}, ty, None);
if !fcx.infcx().is_tainted_by_errors() {
fcx.type_error_message(sp, |_actual| {
"the type of this value must be known in this context".to_string()
}, ty, None);
}
demand::suptype(fcx, sp, fcx.tcx().types.err, ty);
ty = fcx.tcx().types.err;
} else {
Expand Down
67 changes: 67 additions & 0 deletions src/test/compile-fail/issue-31997.rs
@@ -0,0 +1,67 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Regression test for this example from #31997 -- main goal is to
// emit as minimal and precise an error set as possible. Ideally, we'd
// only emit the E0433 error below, but right now we emit two.

use std::io::prelude::*;
// use std::collections::HashMap;
use std::io;

#[derive(Debug)]
struct Instance {
name: String,
start: Option<String>,
end: Option<String>,
}

fn main() {
let input = io::stdin();
let mut input = input.lock();

let mut map = HashMap::new();
//~^ ERROR E0433
//~| ERROR E0425

for line in input.lines() {
let line = line.unwrap();
println!("process: {}", line);
let mut parts = line.splitn(2, ":");
let _logfile = parts.next().unwrap();
let rest = parts.next().unwrap();
let mut parts = line.split(" [-] ");

let stamp = parts.next().unwrap();

let rest = parts.next().unwrap();
let words = rest.split_whitespace().collect::<Vec<_>>();

let instance = words.iter().find(|a| a.starts_with("i-")).unwrap();
let name = words[1].to_owned();
let mut entry = map.entry(instance.to_owned()).or_insert(Instance {
name: name,
start: None,
end: None,
});

if rest.contains("terminating") {
assert!(entry.end.is_none());
entry.end = Some(stamp.to_string());
}
if rest.contains("waiting for") {
assert!(entry.start.is_none());
entry.start = Some(stamp.to_string());
}

}

println!("{:?}", map);
}

0 comments on commit a4e0e6b

Please sign in to comment.