Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
std::sync::TaskPool: Improve module documentation
The struct and module doc comments are reformulated. The `execute` method's documentation are put up to date, and failure information is added. A test is also added to address the possible failure.
- Loading branch information
Showing
1 changed file
with
17 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/alxgnon/rust/commit/af520e133c24f9409f85ac91b0b8bbf033ec0b7a
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alxgnon/rust/taskpooldocfix = af520e1 into auto
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alxgnon/rust/taskpooldocfix = af520e1 merged ok, testing candidate = 9a944c5e
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/5406
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/6302
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/6301
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/5397
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/6399
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/5488
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/5495
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/6402
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/5487
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/5492
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/5553
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3288
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/6392
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/5503
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/alxgnon/rust/commit/af520e133c24f9409f85ac91b0b8bbf033ec0b7a
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alxgnon/rust/taskpooldocfix = af520e1 into auto
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alxgnon/rust/taskpooldocfix = af520e1 merged ok, testing candidate = 75eb50d
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/6303
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/6302
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/5398
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/5407
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/6400
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/5489
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/5496
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/6403
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/5488
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/5493
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/5554
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/3289
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/6393
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/5504
af520e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 75eb50d