Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Exclude build metadata from equality checking.
Build metadata is already excluded from precedence checking in line with the spec. For consistency and providing strict total ordering for Version, build metadata should also be ignored in Eq impl. Closes #12438 Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
- Loading branch information
Showing
1 changed file
with
25 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0a495f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/omasanori/rust/commit/b0a495f0ae70ebbaa0f74ae21c3a1e94a882c6b7
b0a495f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging omasanori/rust/semver-eq = b0a495f into auto
b0a495f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omasanori/rust/semver-eq = b0a495f merged ok, testing candidate = 043c972
b0a495f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4464
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/2306
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/2307
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4462
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/3562
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3568
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4477
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/3565
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3571
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4479
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/3565
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3570
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/3639
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1418
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4471
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/3572
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3578
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4238
b0a495f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 043c972