Skip to content

Commit

Permalink
compiletest needs to link to native crate, or at least the rt library.
Browse files Browse the repository at this point in the history 
(I tried using a dependency on `rustrt` instead, and that did not
resolve the problem.  But this does.)

Fix #17883
  • Loading branch information
@pnkfelix
pnkfelix committed Oct 11, 2014
1 parent 1add4de commit b63a18f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mk/crates.mk
View file
Expand Up @@ -101,7 +101,7 @@ DEPS_regex := std
DEPS_regex_macros = rustc syntax std regex
DEPS_fmt_macros = std

TOOL_DEPS_compiletest := test getopts
TOOL_DEPS_compiletest := test getopts native
TOOL_DEPS_rustdoc := rustdoc native
TOOL_DEPS_rustc := rustc native
TOOL_SOURCE_compiletest := $(S)src/compiletest/compiletest.rs
Expand Down

5 comments on commit b63a18f

@bors
Copy link
Contributor

@bors bors commented on b63a18f Oct 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from huonw
at pnkfelix@b63a18f

@bors
Copy link
Contributor

@bors bors commented on b63a18f Oct 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging pnkfelix/rust/fix-check-stage1-on-clean-dir = b63a18f into auto

@bors
Copy link
Contributor

@bors bors commented on b63a18f Oct 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnkfelix/rust/fix-check-stage1-on-clean-dir = b63a18f merged ok, testing candidate = 4d031d7

@bors
Copy link
Contributor

@bors bors commented on b63a18f Oct 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1749
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1746
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1740
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1746
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1743
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1742
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1742
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1746
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1740
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1739
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1742
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1400
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1397
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1400
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/237
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/237
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/231

@bors
Copy link
Contributor

@bors bors commented on b63a18f Oct 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 4d031d7

Please sign in to comment.