Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove Rng.choose(), rename Rng.choose_option() to .choose()
Rng.choose() is used so rarely that it doesn't necessitate having two methods, especially since the failing, non-option variant also requires Clone. [breaking-change]
- Loading branch information
Showing
2 changed files
with
17 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8270c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at lilyball@b8270c8
b8270c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging kballard/rust/rename_rng_choose_option = b8270c8 into auto
b8270c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kballard/rust/rename_rng_choose_option = b8270c8 merged ok, testing candidate = a400b31
b8270c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5871
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5869
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4965
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4973
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5968
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/5057
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/5065
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5971
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/5056
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/5062
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/5124
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2857
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5964
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/5060
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/5075
b8270c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = a400b31