Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ReaderUtil::each_byte shouldn't include EOF byte -- Issue #5056
- Loading branch information
1 parent
5842ab3
commit b92d1ea
Showing
1 changed file
with
38 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b92d1ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at stepancheg@b92d1ea
b92d1ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging stepancheg/rust/each_byte = b92d1ea into auto
b92d1ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stepancheg/rust/each_byte = b92d1ea merged ok, testing candidate = 293ec2c
b92d1ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/606
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/609
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt/builds/611
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt-vg/builds/604
success: http://buildbot.rust-lang.org/builders/auto-mac-all-opt/builds/607
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/625
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt/builds/628
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/625
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt/builds/629
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt-vg/builds/634
success: http://buildbot.rust-lang.org/builders/auto-linux-all-opt/builds/627
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/609
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt/builds/624
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/398
b92d1ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 293ec2c