Skip to content

Commit

Permalink
partial revert of 31fa865
Browse files Browse the repository at this point in the history 
Ratio is generic and so might contain a non-total orderable type. It
should not use the default Ord implementation.
  • Loading branch information
@dcrewi
dcrewi committed Aug 29, 2013
1 parent 31fa865 commit b9601c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/libextra/num/rational.rs
View file
Expand Up @@ -107,7 +107,7 @@ macro_rules! cmp_impl {
}
cmp_impl!(impl Eq, eq, ne)
cmp_impl!(impl TotalEq, equals)
cmp_impl!(impl Ord, lt)
cmp_impl!(impl Ord, lt, gt, le, ge)
cmp_impl!(impl TotalOrd, cmp -> cmp::Ordering)

impl<T: Clone + Integer + Ord> Orderable for Ratio<T> {
Expand Down

5 comments on commit b9601c4

@bors
Copy link
Contributor

@bors bors commented on b9601c4 Aug 31, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from thestinger
at dcrewi@b9601c4

@bors
Copy link
Contributor

@bors bors commented on b9601c4 Aug 31, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging dcrewi/rust/drop-redundant-ord-impls = b9601c4 into auto

@bors
Copy link
Contributor

@bors bors commented on b9601c4 Aug 31, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dcrewi/rust/drop-redundant-ord-impls = b9601c4 merged ok, testing candidate = 5fe553d

@bors
Copy link
Contributor

@bors bors commented on b9601c4 Aug 31, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1214
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1217
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/323
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/323
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1233
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/324
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/324
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1233
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/324
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/324
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/405
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1217
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/323
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/323
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/1002

@bors
Copy link
Contributor

@bors bors commented on b9601c4 Aug 31, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 5fe553d

Please sign in to comment.