Skip to content

Commit

Permalink
mk: Add -C prefer-dynamic to stage3 libs
Browse files Browse the repository at this point in the history
Right now the windows nightlies are failing because they're encountering a
linker error when producing stage3 libs. The stage3 libs aren't actually used in
general, and we primarily just want to generate a static stage3 binary, not
static stage3 dylibs.
  • Loading branch information
alexcrichton committed Nov 6, 2014
1 parent 60a669a commit bb5f03b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions mk/main.mk
Expand Up @@ -155,6 +155,7 @@ endif
RUSTFLAGS_STAGE0 += -C prefer-dynamic
RUSTFLAGS_STAGE1 += -C prefer-dynamic
RUST_LIB_FLAGS_ST2 += -C prefer-dynamic
RUST_LIB_FLAGS_ST3 += -C prefer-dynamic

# Landing pads require a lot of codegen. We can get through bootstrapping faster
# by not emitting them.
Expand Down

4 comments on commit bb5f03b

@bors
Copy link
Contributor

@bors bors commented on bb5f03b Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from brson
at alexcrichton@bb5f03b

@bors
Copy link
Contributor

@bors bors commented on bb5f03b Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging alexcrichton/rust/fix-windows = bb5f03b into auto

@bors
Copy link
Contributor

@bors bors commented on bb5f03b Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexcrichton/rust/fix-windows = bb5f03b merged ok, testing candidate = 1227b6f1

@bors
Copy link
Contributor

@bors bors commented on bb5f03b Nov 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.