Skip to content

Commit

Permalink
ci: move validate-toolstate.sh in the mingw-check image
Browse files Browse the repository at this point in the history
The task was already run just there, so this cleans things up.
  • Loading branch information
pietroalbini committed Nov 12, 2019
1 parent e209ee4 commit c90cc12
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
8 changes: 0 additions & 8 deletions src/ci/azure-pipelines/steps/run.yml
Expand Up @@ -139,14 +139,6 @@ steps:
condition: and(succeeded(), not(variables.SKIP_JOB))
displayName: Install awscli

# As a quick smoke check on the otherwise very fast mingw-check linux builder
# check our own internal scripts.
- bash: src/ci/scripts/validate-toolstate.sh
env:
TOOLSTATE_REPO_ACCESS_TOKEN: $(TOOLSTATE_REPO_ACCESS_TOKEN)
condition: and(succeeded(), not(variables.SKIP_JOB), eq(variables['IMAGE'], 'mingw-check'))
displayName: Verify the publish_toolstate script works

- bash: src/ci/scripts/run-build-from-ci.sh
timeoutInMinutes: 600
env:
Expand Down
5 changes: 4 additions & 1 deletion src/ci/docker/mingw-check/Dockerfile
Expand Up @@ -19,7 +19,10 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
COPY scripts/sccache.sh /scripts/
RUN sh /scripts/sccache.sh

COPY mingw-check/validate-toolstate.sh /scripts/

ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1
ENV SCRIPT python2.7 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu && \
python2.7 ../x.py build --stage 0 src/tools/build-manifest && \
python2.7 ../x.py test --stage 0 src/tools/compiletest
python2.7 ../x.py test --stage 0 src/tools/compiletest && \
/scripts/validate-toolstate.sh
Expand Up @@ -4,15 +4,16 @@
set -euo pipefail
IFS=$'\n\t'

source "$(cd "$(dirname "$0")" && pwd)/../shared.sh"

rm -rf rust-toolstate
git clone --depth=1 https://github.com/rust-lang-nursery/rust-toolstate.git
cd rust-toolstate
python2.7 "${BUILD_SOURCESDIRECTORY}/src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" "$(git log --format=%s -n1 HEAD)" "" ""
python2.7 "../../src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" \
"$(git log --format=%s -n1 HEAD)" "" ""
# Only check maintainers if this build is supposed to publish toolstate.
# Builds that are not supposed to publish don't have the access token.
if [ -n "${TOOLSTATE_PUBLISH+is_set}" ]; then
TOOLSTATE_VALIDATE_MAINTAINERS_REPO=rust-lang/rust python2.7 "${BUILD_SOURCESDIRECTORY}/src/tools/publish_toolstate.py"
TOOLSTATE_VALIDATE_MAINTAINERS_REPO=rust-lang/rust python2.7 \
"../../src/tools/publish_toolstate.py"
fi
cd ..
rm -rf rust-toolstate

0 comments on commit c90cc12

Please sign in to comment.