Skip to content

Commit

Permalink
Check all files in src/test for borrowck_graphviz_postflow
Browse files Browse the repository at this point in the history
This attribute causes DOT files to be generated in the top-level
directory. It is intended to be used only temporarily and should never
appear on master.

This will prevent #65071 from occurring again.
  • Loading branch information
ecstatic-morse committed Oct 20, 2019
1 parent c491875 commit c9e361f
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 0 deletions.
24 changes: 24 additions & 0 deletions src/tools/tidy/src/debug_artifacts.rs
@@ -0,0 +1,24 @@
//! Tidy check to prevent creation of unnecessary debug artifacts.

use std::path::{Path, PathBuf};

const GRAPHVIZ_POSTFLOW_MSG: &'static str =
"`borrowck_graphviz_postflow` attribute in test";

pub fn check(path: &Path, bad: &mut bool) {
let test_dir: PathBuf = path.join("test");

super::walk(&test_dir, &mut super::filter_dirs, &mut |entry, contents| {
let filename = entry.path();
let is_rust = filename.extension().map_or(false, |ext| ext == "rs");
if !is_rust {
return;
}

for (i, line) in contents.lines().enumerate() {
if line.contains("borrowck_graphviz_postflow") {
tidy_error!(bad, "{}:{}: {}", filename.display(), i + 1, GRAPHVIZ_POSTFLOW_MSG);
}
}
});
}
1 change: 1 addition & 0 deletions src/tools/tidy/src/lib.rs
Expand Up @@ -31,6 +31,7 @@ macro_rules! tidy_error {

pub mod bins;
pub mod style;
pub mod debug_artifacts;
pub mod errors;
pub mod features;
pub mod cargo;
Expand Down
1 change: 1 addition & 0 deletions src/tools/tidy/src/main.rs
Expand Up @@ -22,6 +22,7 @@ fn main() {
let verbose = args.iter().any(|s| *s == "--verbose");
bins::check(&path, &mut bad);
style::check(&path, &mut bad);
debug_artifacts::check(&path, &mut bad);
errors::check(&path, &mut bad);
cargo::check(&path, &mut bad);
edition::check(&path, &mut bad);
Expand Down

0 comments on commit c9e361f

Please sign in to comment.