Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Give a more descriptive error when marking non-test items as #[test]
Closes #14772.
- Loading branch information
Showing
2 changed files
with
41 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// compile-flags: --test | ||
|
||
#[test] | ||
mod foo {} //~ ERROR only functions may be used as tests | ||
|
||
fn main() {} |
cc31d9c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at ftxqxd@cc31d9c
cc31d9c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging P1start/rust/diagnostics = cc31d9c into auto
cc31d9c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1start/rust/diagnostics = cc31d9c merged ok, testing candidate = c586490
cc31d9c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1673
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1670
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1664
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1670
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1667
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1666
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1666
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1670
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1664
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1663
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1666
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1322
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1320
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1324
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/157
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/155
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/154
cc31d9c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = c586490