Skip to content

Commit cc61fc0

Browse files
committed
Removed all instances of XXX in preparation for relaxing of FIXME rule
1 parent 838b5a4 commit cc61fc0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+119
-119
lines changed

Makefile.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ CFG_INFO := $(info cfg: *** compiler is in snapshot transition ***)
636636
CFG_INFO := $(info cfg: *** stage2 and later will not be built ***)
637637
CFG_INFO := $(info cfg:)
638638

639-
#XXX This is surely busted
639+
#FIXME This is surely busted
640640
all: $(SREQ1$(CFG_BUILD)) $(GENERATED) docs
641641

642642
else

doc/tutorial.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2895,7 +2895,7 @@ and only if that results in no match look at items you brought in
28952895
scope with corresponding `use` statements.
28962896

28972897
~~~ {.ignore}
2898-
# // XXX: Allow unused import in doc test
2898+
# // FIXME: Allow unused import in doc test
28992899
use farm::cow;
29002900
// ...
29012901
# mod farm { pub fn cow() { println!("Hidden ninja cow is hidden.") } }

mk/platform.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ define CFG_MAKE_TOOLCHAIN
596596
else
597597

598598
# For the ARM and MIPS crosses, use the toolchain assembler
599-
# XXX: We should be able to use the LLVM assembler
599+
# FIXME: We should be able to use the LLVM assembler
600600
CFG_ASSEMBLE_$(1)=$$(CC_$(1)) $$(CFG_GCCISH_CFLAGS_$(1)) \
601601
$$(CFG_DEPEND_FLAGS) $$(2) -c -o $$(1)
602602

src/libextra/arena.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ impl Arena {
276276
#[inline]
277277
pub fn alloc<'a, T>(&'a self, op: || -> T) -> &'a T {
278278
unsafe {
279-
// XXX: Borrow check
279+
// FIXME: Borrow check
280280
let this = transmute_mut(self);
281281
if intrinsics::needs_drop::<T>() {
282282
this.alloc_nonpod(op)

src/libextra/ebml.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,7 @@ pub mod writer {
630630

631631
// FIXME (#2741): Provide a function to write the standard ebml header.
632632
impl<'a> Encoder<'a> {
633-
/// XXX(pcwalton): Workaround for badness in trans. DO NOT USE ME.
633+
/// FIXME(pcwalton): Workaround for badness in trans. DO NOT USE ME.
634634
pub unsafe fn unsafe_clone(&self) -> Encoder<'a> {
635635
Encoder {
636636
writer: cast::transmute_copy(&self.writer),

src/libextra/glob.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ pub fn glob_with(pattern: &str, options: MatchOptions) -> Paths {
9393
let pat_root = Path::new(pattern).root_path();
9494
if pat_root.is_some() {
9595
if check_windows_verbatim(pat_root.get_ref()) {
96-
// XXX: How do we want to handle verbatim paths? I'm inclined to return nothing,
96+
// FIXME: How do we want to handle verbatim paths? I'm inclined to return nothing,
9797
// since we can't very well find all UNC shares with a 1-letter server name.
9898
return Paths { root: root, dir_patterns: ~[], options: options, todo: ~[] };
9999
}

src/libextra/url.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ fn decode_inner(s: &str, full_url: bool) -> ~str {
174174
let mut bytes = [0, 0];
175175
match rdr.read(bytes) {
176176
Some(2) => {}
177-
_ => fail!() // XXX: malformed url?
177+
_ => fail!() // FIXME: malformed url?
178178
}
179179
let ch = uint::parse_bytes(bytes, 16u).unwrap() as u8 as char;
180180

@@ -308,7 +308,7 @@ pub fn decode_form_urlencoded(s: &[u8]) -> HashMap<~str, ~[~str]> {
308308
let mut bytes = [0, 0];
309309
match rdr.read(bytes) {
310310
Some(2) => {}
311-
_ => fail!() // XXX: malformed?
311+
_ => fail!() // FIXME: malformed?
312312
}
313313
uint::parse_bytes(bytes, 16u).unwrap() as u8 as char
314314
}

src/libextra/workcache.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ impl<'a> Prep<'a> {
413413
let (port, chan) = Chan::new();
414414
let blk = bo.take_unwrap();
415415

416-
// XXX: What happens if the task fails?
416+
// FIXME: What happens if the task fails?
417417
do spawn {
418418
let mut exe = Exec {
419419
discovered_inputs: WorkMap::new(),

src/libgreen/basic.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ impl EventLoop for BasicLoop {
139139
self.work.push(f);
140140
}
141141

142-
// XXX: Seems like a really weird requirement to have an event loop provide.
142+
// FIXME: Seems like a really weird requirement to have an event loop provide.
143143
fn pausable_idle_callback(&mut self, cb: ~Callback) -> ~PausableIdleCallback {
144144
let callback = ~BasicPausable::new(self, cb);
145145
rtassert!(self.idle.is_none());

src/libgreen/macros.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
// XXX: this file probably shouldn't exist
11+
// FIXME: this file probably shouldn't exist
1212

1313
#[macro_escape];
1414

1515
use std::fmt;
1616

1717
// Indicates whether we should perform expensive sanity checks, including rtassert!
18-
// XXX: Once the runtime matures remove the `true` below to turn off rtassert, etc.
18+
// FIXME: Once the runtime matures remove the `true` below to turn off rtassert, etc.
1919
pub static ENFORCE_SANITY: bool = true || !cfg!(rtopt) || cfg!(rtdebug) || cfg!(rtassert);
2020

2121
macro_rules! rterrln (

0 commit comments

Comments
 (0)