Skip to content

Commit

Permalink
be more robust when removing download artifacts and remove bogus rais…
Browse files Browse the repository at this point in the history
…e statement
  • Loading branch information
benjaminp committed Nov 13, 2013
1 parent 825b127 commit d328ab7
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/etc/snapshot.py
Expand Up @@ -148,8 +148,11 @@ def get_url_to_file(u,f):
returncode = subprocess.call(["wget", "-O", tmpf, u])

if returncode != 0:
os.unlink(tmpf)
raise
try:
os.unlink(tmpf)
except OSError as e:
pass
raise Exception("failed to fetch url")
os.rename(tmpf, f)

def snap_filename_hash_part(snap):
Expand Down

9 comments on commit d328ab7

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from pnkfelix
at benjaminp@d328ab7

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging gutworth/rust/snap-err = d328ab7 into auto

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gutworth/rust/snap-err = d328ab7 merged ok, testing candidate = 60af4f79

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 13, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from pnkfelix
at benjaminp@d328ab7

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging gutworth/rust/snap-err = d328ab7 into auto

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gutworth/rust/snap-err = d328ab7 merged ok, testing candidate = 8a3b35f

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on d328ab7 Nov 14, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 8a3b35f

Please sign in to comment.