Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
extend
unused_extern_crates
lint with a suggestion to remove
- Loading branch information
1 parent
577a5b2
commit d5010ec
Showing
4 changed files
with
89 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
src/test/ui/rust-2018/extern-crate-idiomatic-in-2018.fixed
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// aux-build:edition-lint-paths.rs | ||
// run-rustfix | ||
// compile-flags:--edition 2018 | ||
|
||
// The "normal case". Ideally we would remove the `extern crate` here, | ||
// but we don't. | ||
|
||
#![feature(rust_2018_preview)] | ||
#![deny(absolute_path_not_starting_with_crate)] | ||
#![deny(unused_extern_crates)] | ||
#![allow(dead_code)] | ||
|
||
|
||
//~^ ERROR unused extern crate | ||
|
||
extern crate edition_lint_paths as bar; | ||
|
||
fn main() { | ||
// This is not considered to *use* the `extern crate` in Rust 2018: | ||
use edition_lint_paths::foo; | ||
foo(); | ||
|
||
// But this should be a use of the (renamed) crate: | ||
crate::bar::foo(); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// aux-build:edition-lint-paths.rs | ||
// run-rustfix | ||
// compile-flags:--edition 2018 | ||
|
||
// The "normal case". Ideally we would remove the `extern crate` here, | ||
// but we don't. | ||
|
||
#![feature(rust_2018_preview)] | ||
#![deny(absolute_path_not_starting_with_crate)] | ||
#![deny(unused_extern_crates)] | ||
#![allow(dead_code)] | ||
|
||
extern crate edition_lint_paths; | ||
//~^ ERROR unused extern crate | ||
|
||
extern crate edition_lint_paths as bar; | ||
|
||
fn main() { | ||
// This is not considered to *use* the `extern crate` in Rust 2018: | ||
use edition_lint_paths::foo; | ||
foo(); | ||
|
||
// But this should be a use of the (renamed) crate: | ||
crate::bar::foo(); | ||
} | ||
|
14 changes: 14 additions & 0 deletions
14
src/test/ui/rust-2018/extern-crate-idiomatic-in-2018.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
error: unused extern crate | ||
--> $DIR/extern-crate-idiomatic-in-2018.rs:23:1 | ||
| | ||
LL | extern crate edition_lint_paths; | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it | ||
| | ||
note: lint level defined here | ||
--> $DIR/extern-crate-idiomatic-in-2018.rs:20:9 | ||
| | ||
LL | #![deny(unused_extern_crates)] | ||
| ^^^^^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to previous error | ||
|