Skip to content

Commit

Permalink
rustdoc: remove the ! from macro URLs and titles
Browse files Browse the repository at this point in the history
  • Loading branch information
nrc committed Aug 18, 2016
1 parent aef6971 commit da1f773
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions src/librustdoc/clean/mod.rs
Expand Up @@ -2803,7 +2803,7 @@ pub struct Macro {

impl Clean<Item> for doctree::Macro {
fn clean(&self, cx: &DocContext) -> Item {
let name = format!("{}!", self.name.clean(cx));
let name = self.name.clean(cx);
Item {
name: Some(name.clone()),
attrs: self.attrs.clean(cx),
Expand All @@ -2814,8 +2814,10 @@ impl Clean<Item> for doctree::Macro {
def_id: cx.map.local_def_id(self.id),
inner: MacroItem(Macro {
source: format!("macro_rules! {} {{\n{}}}",
name.trim_right_matches('!'), self.matchers.iter().map(|span|
format!(" {} => {{ ... }};\n", span.to_src(cx))).collect::<String>()),
name,
self.matchers.iter().map(|span| {
format!(" {} => {{ ... }};\n", span.to_src(cx))
}).collect::<String>()),
imported_from: self.imported_from.clean(cx),
}),
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-26606.rs
Expand Up @@ -12,7 +12,7 @@
// ignore-cross-compile
// build-aux-docs

// @has issue_26606_macro/macro.make_item!.html
// @has issue_26606_macro/macro.make_item.html
#[macro_use]
extern crate issue_26606_macro;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/macros.rs
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// @has macros/macro.my_macro!.html //pre 'macro_rules! my_macro {'
// @has macros/macro.my_macro.html //pre 'macro_rules! my_macro {'
// @has - //pre '() => { ... };'
// @has - //pre '($a:tt) => { ... };'
// @has - //pre '($e:expr) => { ... };'
Expand Down

0 comments on commit da1f773

Please sign in to comment.