Skip to content

Commit

Permalink
Remove few FIXMEs
Browse files Browse the repository at this point in the history
This commit removes FIXMEs of few closed issues.

Closes #13992
  • Loading branch information
Sawyer47 authored and alexcrichton committed Jun 25, 2014
1 parent 5807800 commit e4e3550
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 19 deletions.
5 changes: 2 additions & 3 deletions src/test/compile-fail/issue-9725.rs
Expand Up @@ -8,10 +8,9 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-test FIXME: #13992

struct A { foo: int }

fn main() {
let A { foo, foo } = A { foo: 3 }; //~ ERROR: field `foo` bound twice
let A { foo, foo } = A { foo: 3 };
//~^ ERROR: identifier `foo` is bound more than once in the same pattern
}
10 changes: 2 additions & 8 deletions src/test/compile-fail/regionck-closure-lifetimes.rs
Expand Up @@ -8,25 +8,19 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn env<'a>(_: &'a uint, blk: |p: ||: 'a|) {
fn env<'a>(blk: |p: ||: 'a|) {
// Test that the closure here cannot be assigned
// the lifetime `'a`, which outlives the current
// block.
//
// FIXME(#4846): The `&'a uint` parameter is needed to ensure that `'a`
// is a free and not bound region name.

let mut state = 0;
let statep = &mut state;
blk(|| *statep = 1); //~ ERROR cannot infer
}

fn no_env_no_for<'a>(_: &'a uint, blk: |p: |||: 'a) {
fn no_env_no_for<'a>(blk: |p: |||: 'a) {
// Test that a closure with no free variables CAN
// outlive the block in which it is created.
//
// FIXME(#4846): The `&'a uint` parameter is needed to ensure that `'a`
// is a free and not bound region name.

blk(|| ())
}
Expand Down
4 changes: 1 addition & 3 deletions src/test/run-pass/item-attributes.rs
Expand Up @@ -95,19 +95,17 @@ mod test_stmt_multi_attr_outer {
#[attr2 = "val"]
fn f() { }

/* FIXME: Issue #493
#[attr1 = "val"]
#[attr2 = "val"]
mod mod1 {
}

pub mod rustrt {
mod rustrt {
#[attr1 = "val"]
#[attr2 = "val"]
extern {
}
}
*/
}
}

Expand Down
2 changes: 0 additions & 2 deletions src/test/run-pass/reexport-star.rs
Expand Up @@ -11,8 +11,6 @@

#![feature(globs)]

// FIXME #3654

mod a {
pub fn f() {}
pub fn g() {}
Expand Down
5 changes: 2 additions & 3 deletions src/test/run-pass/trait-generic.rs
Expand Up @@ -29,9 +29,8 @@ trait map<T> {
impl<T> map<T> for Vec<T> {
fn map<U>(&self, f: |&T| -> U) -> Vec<U> {
let mut r = Vec::new();
// FIXME: #7355 generates bad code with VecIterator
for i in range(0u, self.len()) {
r.push(f(self.get(i)));
for i in self.iter() {
r.push(f(i));
}
r
}
Expand Down

0 comments on commit e4e3550

Please sign in to comment.