Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libsyntax: Forbid type parameters in field expressions.
This breaks code like: struct Foo { x: int, } let f: Foo = ...; ... f.x::<int> ... Change this code to not contain an unused type parameter. For example: struct Foo { x: int, } let f: Foo = ...; ... f.x ... Closes #18680. [breaking-change]
- Loading branch information
Showing
2 changed files
with
32 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
struct Foo { | ||
x: int, | ||
y: int, | ||
} | ||
|
||
fn main() { | ||
let f = Foo { | ||
x: 1, | ||
y: 2, | ||
}; | ||
f.x::<int>; | ||
//~^ ERROR field expressions may not have type parameters | ||
} | ||
|
e6e58e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from aturon
at pcwalton@e6e58e4
e6e58e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pcwalton/rust/path-silliness = e6e58e4 into auto
e6e58e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pcwalton/rust/path-silliness = e6e58e4 merged ok, testing candidate = 82f3838
e6e58e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2241
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2239
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2232
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2239
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2233
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2232
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2232
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2236
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2229
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2228
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2232
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1891
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1888
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1895
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/732
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/725
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/719
e6e58e4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 82f3838