Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is much faster for strings, and eventually when there is a buffered reader of some sort. Reading example.json 100 times before was around 1.18s. After: - reading from string 0.68s - reading from file 1.08s (extra time is all in io::Reader)
- Loading branch information
Showing
1 changed file
with
26 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f091a1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from erickt
at glinscott@f091a1e
f091a1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging glinscott/rust/json_iter = f091a1e into auto
f091a1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glinscott/rust/json_iter = f091a1e merged ok, testing candidate = 06accaf
f091a1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/355
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/357
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt/builds/360
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt-vg/builds/353
success: http://buildbot.rust-lang.org/builders/auto-mac-all-opt/builds/357
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/376
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt/builds/379
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/376
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt/builds/379
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt-vg/builds/382
success: http://buildbot.rust-lang.org/builders/auto-linux-all-opt/builds/375
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/359
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt/builds/375
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/154
f091a1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 06accaf