Skip to content

Commit

Permalink
s/method/associated function/ in E0201
Browse files Browse the repository at this point in the history
  • Loading branch information
Nick Hamann committed Jun 3, 2015
1 parent dc1e79b commit f1db9cd
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/librustc_typeck/collect.rs
Expand Up @@ -752,7 +752,7 @@ fn convert_methods<'a,'tcx,'i,I>(ccx: &CrateCtxt<'a, 'tcx>,
let mut seen_methods = FnvHashSet();
for (sig, id, ident, vis, span) in methods {
if !seen_methods.insert(ident.name) {
span_err!(tcx.sess, span, E0201, "duplicate method");
span_err!(tcx.sess, span, E0201, "duplicate associated function");
}

convert_method(ccx,
Expand Down
20 changes: 15 additions & 5 deletions src/librustc_typeck/diagnostics.rs
Expand Up @@ -880,19 +880,29 @@ unsafe impl Bar for Foo { }
"##,

E0201: r##"
It is an error to define a method--a trait method or an inherent method--more
than once.
It is an error to define an associated function more than once.
For example,
For example:
```
struct Foo(u8);
impl Foo {
fn bar(&self) -> bool { self.0 > 5 }
// error: duplicate associated function
fn bar() {}
}
// error: duplicate method
fn bar(&self) -> bool { self.0 > 5 }
trait Baz {
fn baz(&self) -> bool;
}
impl Baz for Foo {
fn baz(&self) -> bool { true }
// error: duplicate associated function
fn baz(&self) -> bool { self.0 > 5 }
}
```
"##,
Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/impl-duplicate-methods.rs
Expand Up @@ -11,7 +11,7 @@
struct Foo;
impl Foo {
fn orange(&self){}
fn orange(&self){} //~ ERROR error: duplicate method
fn orange(&self){} //~ ERROR duplicate associated function
}

fn main() {}
2 changes: 1 addition & 1 deletion src/test/compile-fail/issue-4265.rs
Expand Up @@ -17,7 +17,7 @@ impl Foo {
Foo { baz: 0 }.bar();
}

fn bar() { //~ ERROR duplicate method
fn bar() { //~ ERROR duplicate associated function
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/issue-8153.rs
Expand Up @@ -18,7 +18,7 @@ trait Bar {

impl Bar for Foo {
fn bar(&self) -> isize {1}
fn bar(&self) -> isize {2} //~ ERROR duplicate method
fn bar(&self) -> isize {2} //~ ERROR duplicate associated function
}

fn main() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/compile-fail/method-macro-backtrace.rs
Expand Up @@ -29,7 +29,7 @@ impl S {

// Cause an error. It shouldn't have any macro backtrace frames.
fn bar(&self) { }
fn bar(&self) { } //~ ERROR duplicate method
fn bar(&self) { } //~ ERROR duplicate associated function
}

fn main() { }

0 comments on commit f1db9cd

Please sign in to comment.