Skip to content

Commit

Permalink
Order list of linted files by frequency
Browse files Browse the repository at this point in the history
Since it makes more sense for .rs files to appear at the top of the
list of linted files and "other" files to appear at the end, this
commit moves the "other" count outside of the `file_counts` dictionary
and sorts the remaining "interesting" files by decreasing frequency.
  • Loading branch information
iKevinY committed Feb 24, 2015
1 parent 7884eb8 commit f1eebb8
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions src/etc/tidy.py
Expand Up @@ -66,20 +66,22 @@ def do_license_check(name, contents):
try:
count_lines = 0
count_non_blank_lines = 0
count_other_linted_files = 0

interesting_files = ['.rs', '.py', '.js', '.sh', '.c', '.h']

file_counts = {ext: 0 for ext in interesting_files}
file_counts['other'] = 0

def update_counts(current_name):
global file_counts
global count_other_linted_files

_, ext = os.path.splitext(current_name)

if ext in file_counts:
if ext in interesting_files:
file_counts[ext] += 1
else:
file_counts['other'] += 1
count_other_linted_files += 1

all_paths = set()

Expand Down Expand Up @@ -196,10 +198,11 @@ def interesting_file(f):
report_err("UTF-8 decoding error " + str(e))

print
for ext in file_counts:
print "* linted " + str(file_counts[ext]) + " " + ext + " files"
print "* total lines of code: " + str(count_lines)
print "* total non-blank lines of code: " + str(count_non_blank_lines)
for ext in sorted(file_counts, key=file_counts.get, reverse=True):
print "* linted {} {} files".format(file_counts[ext], ext)
print "* linted {} other files".format(count_other_linted_files)
print "* total lines of code: {}".format(count_lines)
print "* total non-blank lines of code: {}".format(count_non_blank_lines)
print

sys.exit(err)

0 comments on commit f1eebb8

Please sign in to comment.